git-messenger 使用git-link 函数问题

ztlevi · 2018 年10 月 1 日 18:17

我想在git-messenger下使用apply prefix arg的git-link的函数。

方案1

下面这样定义后，M-x git-link-commit--C-u是可以使用的，但是无法在git-messenger内使用（复现 M-x git-messenger:popup-message → o）。

(defmacro call-function--with-prefix-arg (func &rest arglist)
  "defmacro to create functions call with prefix arg"
  `(defun ,(intern (format "%S--C-u" func)) ,arglist
     (interactive)
     (let ((current-prefix-arg '(4)))
       (call-interactively ',func))))

;; git-link
(call-function--with-prefix-arg git-link-commit)
(define-key git-messenger-map (kbd "o") 'git-link-commit--C-u)
(setq git-messenger:func-prompt (cons '(git-link-commit--C-u . "Browse Remote") git-messenger:func-prompt ))

方案2

但是我这样定义git-link-commit的函数，在git-messenger下使用就行 spacemacs-config/funcs.el at master · ztlevi/spacemacs-config · GitHub 。这种我是直接把C-u加在函数体里了。

(define-key git-messenger-map (kbd "o") 'my-git-link-commit)
(setq git-messenger:func-prompt (cons '(my-git-link-commit . "Browse Remote") git-messenger:func-prompt ))

求教如何解决这个问题，能够让第一种方式正常使用。

xuchunyang · 2018 年10 月 1 日 23:33

你的 my-git-link-commit 还改了 git-link-commit 中获得 commit 的获取方式，所以方案 1 无法工作（更准确地说，估计会提示 “Point is not on a commit hash”）可能是理所当然的。

github.com

ztlevi/spacemacs-config/blob/6dc550042c7ad4aedda2d4213b476ab27b9d34a1/layers/ztlevi-misc/funcs.el#L613


      
          
          
(interactive)
          (require 'git-link)
          (let ((current-prefix-arg '(4)))
            (setq-local remote (git-link--select-remote))
            (let* (commit handler remote-info (remote-url (git-link--remote-url remote)))
              (if (null remote-url)
                  (message "Remote `%s' not found" remote)
          
          
      (setq remote-info (git-link--parse-remote remote-url)
                      commit git-messenger:last-commit-id
                      handler (git-link--handler git-link-commit-remote-alist (car remote-info)))
          
          
      (cond ((null (car remote-info))
                       (message "Remote `%s' contains an unsupported URL" remote))
                      ((not (string-match-p "[a-fA-F0-9]\\{7,40\\}" (or commit "")))
                       (message "Point is not on a commit hash"))
                      ((not (functionp handler))
                       (message "No handler for %s" (car remote-info)))
                      ;; null ret val
                      ((git-link--new

github.com

sshaw/git-link/blob/efd14ab5f17f5942d25e165210447f3983f3250e/git-link.el#L499


      
          
          
With a prefix argument prompt for the remote's name.
          Defaults to \"origin\"."
          
          
  (interactive (list (git-link--select-remote)))
            (let* (commit handler remote-info (remote-url (git-link--remote-url remote)))
              (if (null remote-url)
                  (message "Remote `%s' not found" remote)
          
          
      (setq remote-info (git-link--parse-remote remote-url)
                      commit (word-at-point)
                      handler (git-link--handler git-link-commit-remote-alist (car remote-info)))
          
          
      (cond ((null (car remote-info))
                       (message "Remote `%s' contains an unsupported URL" remote))
                      ((not (string-match-p "[a-fA-F0-9]\\{7,40\\}" (or commit "")))
                       (message "Point is not on a commit hash"))
                      ((not (functionp handler))
                       (message "No handler for %s" (car remote-info)))
                      ;; null ret val
                      ((git-link--new

ztlevi · 2018 年10 月 2 日 00:30

对啊。。。我之前改的都忘记了。thx