eglot 可以补全，但是code-actions 都报错。

monk0 · 2023 年2 月 14 日 05:46

各位大佬：在使用eglot客户端版本号：eglot-20221020.1010，lsp server版本号jdt-language-server-1.18.0-202212011657，lsp server通过本地bat脚本启动。代码提示可以正常使用，但是执行code-actions时报错，具体日志如下，大神帮看看，或者给个排查思路，谢谢

[eglot] Connected! Server EGLOT (Test/(java-mode))' now managing (java-mode)’ buffers in project `Test’.

[eglot] (warning) Server tried to register unsupported capability `workspace/didChangeWorkspaceFolders’

jsonrpc-error: “request id=11 failed:”, (jsonrpc-error-code . -32601), (jsonrpc-error-message . “No delegateCommandHandler for java.apply.workspaceEdit”), (jsonrpc-error-data)

jsonrpc-error: “request id=16 failed:”, (jsonrpc-error-code . -32601), (jsonrpc-error-message . “No delegateCommandHandler for java.apply.workspaceEdit”), (jsonrpc-error-data)

zsxh · 2023 年2 月 14 日 06:36

看起来是 eglot 没有实现 java.apply.workspaceEdit 这个操作

github.com/eclipse/eclipse.jdt.ls

No delegateCommandHandler for java.apply.workspaceEdit

opened 05:01PM - 03 Oct 17 UTC

idanarye

bug client/integration client/communication

I'm using jdt.ls via [LanguageClient-neovim](https://github.com/autozimu/Languag…eClient-neovim), and I'm trying to use code actions. This is my file: ```java public class App { public static void main(String[] args) { JFrame frame = new JFrame(); } } ``` `JFrame` is linted because I did not import it, and the LS suggests some code actions(this is from the log of the client - I just formatted the JSON lines to make them readable): ```json 17:06:19 INFO [MainThread] Begin textDocument/codeAction 17:06:19 DEBUG [MainThread] => { "jsonrpc": "2.0", "id": 1, "method": "textDocument/codeAction", "params": { "textDocument": { "uri": "file:///files/tests/java/45/src/main/java/App.java" }, "range": { "start": { "line": 2, "character": 8 }, "end": { "line": 2, "character": 14 } }, "context": { "diagnostics": [ { "range": { "start": { "line": 2, "character": 8 }, "end": { "line": 2, "character": 14 } }, "severity": 1, "code": "16777218", "source": "Java", "message": "JFrame cannot be resolved to a type" } ] } } } 17:06:19 DEBUG [RPC-java ] <= {"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"Oct 3, 2017 5:05:52 PM \u003e\u003e document/codeAction"}} 17:06:19 DEBUG [RPC-java ] <= { "jsonrpc": "2.0", "id": "1", "result": [ { "title": "Change to 'JobName' (javax.print.attribute.standard)", "command": "java.apply.workspaceEdit", "arguments": [ { "changes": { "file:///files/tests/java/45/src/main/java/App.java": [ { "range": { "start": { "line": 0, "character": 0 }, "end": { "line": 0, "character": 0 } }, "newText": "import javax.print.attribute.standard.JobName;" }, { "range": { "start": { "line": 0, "character": 0 }, "end": { "line": 0, "character": 0 } }, "newText": "\n\n" }, { "range": { "start": { "line": 2, "character": 8 }, "end": { "line": 2, "character": 8 } }, "newText": "JobName" }, { "range": { "start": { "line": 2, "character": 8 }, "end": { "line": 2, "character": 14 } }, "newText": "" } ] } } ] }, { "title": "Import 'JFrame' (javax.swing)", "command": "java.apply.workspaceEdit", "arguments": [ { "changes": { "file:///files/tests/java/45/src/main/java/App.java": [ { "range": { "start": { "line": 0, "character": 0 }, "end": { "line": 0, "character": 0 } }, "newText": "import javax.swing.JFrame;" }, { "range": { "start": { "line": 0, "character": 0 }, "end": { "line": 0, "character": 0 } }, "newText": "\n\n" } ] } } ] }, { "title": "Add type parameter 'JFrame' to 'main(String[])'", "command": "java.apply.workspaceEdit", "arguments": [ { "changes": { "file:///files/tests/java/45/src/main/java/App.java": [ { "range": { "start": { "line": 1, "character": 18 }, "end": { "line": 1, "character": 18 } }, "newText": "<" }, { "range": { "start": { "line": 1, "character": 18 }, "end": { "line": 1, "character": 18 } }, "newText": "JFrame" }, { "range": { "start": { "line": 1, "character": 18 }, "end": { "line": 1, "character": 18 } }, "newText": "> " } ] } } ] } ] } 17:06:19 DEBUG [MainThread] state.codeActionCommands: [] => [ { "title": "Change to 'JobName' (javax.print.attribute.standard)", "command": "java.apply.workspaceEdit", "arguments": [ { "changes": { "file:///files/tests/java/45/src/main/java/App.java": [ { "range": { "start": { "line": 0, "character": 0 }, "end": { "line": 0, "character": 0 } }, "newText": "import javax.print.attribute.standard.JobName;" }, { "range": { "start": { "line": 0, "character": 0 }, "end": { "line": 0, "character": 0 } }, "newText": "\n\n" }, { "range": { "start": { "line": 2, "character": 8 }, "end": { "line": 2, "character": 8 } }, "newText": "JobName" }, { "range": { "start": { "line": 2, "character": 8 }, "end": { "line": 2, "character": 14 } }, "newText": "" } ] } } ] }, { "title": "Import 'JFrame' (javax.swing)", "command": "java.apply.workspaceEdit", "arguments": [ { "changes": { "file:///files/tests/java/45/src/main/java/App.java": [ { "range": { "start": { "line": 0, "character": 0 }, "end": { "line": 0, "character": 0 } }, "newText": "import javax.swing.JFrame;" }, { "range": { "start": { "line": 0, "character": 0 }, "end": { "line": 0, "character": 0 } }, "newText": "\n\n" } ] } } ] }, { "title": "Add type parameter 'JFrame' to 'main(String[])'", "command": "java.apply.workspaceEdit", "arguments": [ { "changes": { "file:///files/tests/java/45/src/main/java/App.java": [ { "range": { "start": { "line": 1, "character": 18 }, "end": { "line": 1, "character": 18 } }, "newText": "<" }, { "range": { "start": { "line": 1, "character": 18 }, "end": { "line": 1, "character": 18 } }, "newText": "JFrame" }, { "range": { "start": { "line": 1, "character": 18 }, "end": { "line": 1, "character": 18 } }, "newText": "> " } ] } } ] } ] 17:06:19 INFO [MainThread] End textDocument/codeAction ``` So I pick `Import 'JFrame' (javax.swing)`: ```json 17:06:44 INFO [MainThread] Begin workspace/executeCommand 17:06:44 DEBUG [MainThread] => { "jsonrpc": "2.0", "id": 2, "method": "workspace/executeCommand", "params": { "command": "java.apply.workspaceEdit", "arguments": [ { "changes": { "file:///files/tests/java/45/src/main/java/App.java": [ { "range": { "start": { "line": 0, "character": 0 }, "end": { "line": 0, "character": 0 } }, "newText": "import javax.print.attribute.standard.JobName;" }, { "range": { "start": { "line": 0, "character": 0 }, "end": { "line": 0, "character": 0 } }, "newText": "\n\n" }, { "range": { "start": { "line": 2, "character": 8 }, "end": { "line": 2, "character": 8 } }, "newText": "JobName" }, { "range": { "start": { "line": 2, "character": 8 }, "end": { "line": 2, "character": 14 } }, "newText": "" } ] } } ] } } 17:06:44 DEBUG [RPC-java ] <= {"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"Oct 3, 2017 5:05:52 PM \u003e\u003e workspace/executeCommand"}} 17:06:44 DEBUG [RPC-java ] <= {"jsonrpc":"2.0","id":"2","error":{"code":-32601,"message":"No delegateCommandHandler for java.apply.workspaceEdit"}} 17:06:44 ERROR [MainThread] {"jsonrpc": "2.0", "id": "2", "error": {"code": -32601, "message": "No delegateCommandHandler for java.apply.workspaceEdit"}} 17:06:44 INFO [MainThread] End workspace/executeCommand ``` And get the error message - `No delegateCommandHandler for java.apply.workspaceEdit` The LSP specs does not seem to refer to `delegateCommandHandler`s, and from #346 it looks like it's jdt.ls' extension - but I don't see any instructions on how to use it. So... what do I need to do to add support for it in a client?

java.apply.workspaceEdit is not related to delegateCommandHandlers actually (those are server side extensions). It’s a command that needs to be implemented by clients. See how it’s done in vscode-java:

github.com

redhat-developer/vscode-java/blob/9b0f0aca80cbefabad4c034fb5dd365d029f6170/src/extension.ts#L155-L160


      
          					commands.registerCommand(Commands.APPLY_WORKSPACE_EDIT, (obj) => {
          						let edit = languageClient.protocol2CodeConverter.asWorkspaceEdit(obj);
          						if (edit) {
          							workspace.applyEdit(edit);
          						}
          					});

Basically, the server sends workspace edits to the client, and the client is responsible for applying them.

monk0 · 2023 年2 月 14 日 06:43

感谢回复，这个帖子我也看到了。从回复看，需要通过扩展实现，但是查阅了eglot的文档，没看到有类似的扩展。

monk0 · 2023 年2 月 14 日 07:58

翻了eglot issue ，找到作者建议的方案。

(cl-defmethod eglot-execute-command (_server (_cmd (eql java.apply.workspaceEdit)) arguments) “Eclipse JDT breaks spec and replies with edits as arguments.” (mapc #'eglot–apply-workspace-edit arguments))

原问题地址：

github.com/joaotavora/eglot

Fix code actions on Eclipse JDT Language server

joaotavora:master ← beji:fix-jdtls-java-apply-workspaceedit

opened 03:03PM - 27 Apr 22 UTC

beji

+8 -0

jdtls breaks the spec, which in turn breaks code actions. There is no real solut…ion to this issue so this behaviour needs a workaround. This was already implemented in eglot but got removed removed when https://github.com/joaotavora/eglot/pull/864 was merged so the corresponding code is reintroduced. See https://github.com/eclipse/eclipse.jdt.ls/issues/376 for the upstream issue.

LuciusChen · 2023 年8 月 11 日 06:18

直接复制这段代码么，我看并没有解决这个 warning，而且示例代码写成了 cll-defmethod

archer.wang · 2023 年8 月 11 日 11:10

我看你在这里 Fix code actions on Eclipse JDT Language server 留言了，这个是我验证的结果，master分支，不需要那个补丁了，原因是 Eglot 实现了:codeAction/resolve，之前执行命令的代码重写了。

而且master分支里eglot-execute-command命令已经废弃了。

(cl-defgeneric eglot-execute-command (_ _ _)
  (declare (obsolete eglot-execute "30.1"))
  (:method
   (server command arguments)
   (eglot--request server :workspace/executeCommand
                   `(:command ,(format "%s" command) :arguments ,arguments))))

我本地操作：

codeAction 实现方法

LuciusChen · 2023 年8 月 11 日 13:39

感谢回复，那么你用的什么 debug 呢，或者说你的 java 开发在 emacs 里的工作流是什么样子的啊，目前正在从 idea 我迁移到 emacs。